Skip to content

Refactor : RPPL-3560 Remove PrivacySettings contracts and processors from Ripple #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Refactor : RPPL-3560 Remove PrivacySettings contracts and processors from Ripple #903

wants to merge 8 commits into from

Conversation

@Vinodsathyaseelan
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@Vinodsathyaseelan Vinodsathyaseelan requested review from a team September 30, 2025 17:22
maggie98choy
maggie98choy previously approved these changes Oct 2, 2025
View reviewed changes
@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/903/rdkcentral/Ripple

  • Commit: a1c28ad

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/903/rdkcentral/Ripple

  • Commit: c15c579

Report detail: gist'

@github-actions
Copy link

Code Coverage

Package Line Rate Health
core.sdk.src.api.manifest 74% ➖
core.sdk.src.service 42% ❌
core.sdk.src.api.gateway 69% ➖
core.main.src.broker.rules 78% ✔
core.main.src.service.apps 25% ❌
device.thunder_ripple_sdk.src.events 4% ❌
core.main.src.state.cap 42% ❌
core.main.src.bootstrap 0% ❌
core.main.src.broker.test 90% ✔
core.main.src.firebolt 12% ❌
core.main.src.bootstrap.extn 0% ❌
core.main.src.service.ripple_service 9% ❌
device.thunder_ripple_sdk.src.processors 19% ❌
core.tdk.src.gateway 100% ✔
core.main.src.processor 0% ❌
core.main.src.utils 30% ❌
device.thunder_ripple_sdk.src.bootstrap 0% ❌
core.sdk.src.api.device 76% ✔
core.sdk.src.processor 6% ❌
core.sdk.src.utils 63% ➖
core.main.src.service.extn 25% ❌
core.main.src.broker 70% ➖
core.sdk.src.framework 64% ➖
core.sdk.src.manifest 0% ❌
core.main.src.service 32% ❌
core.sdk.src.api.distributor 29% ❌
device.mock_device.src 55% ➖
core.main.src.firebolt.handlers 11% ❌
core.main.src.state 36% ❌
core.sdk.src.api 45% ❌
core.main.src.bootstrap.manifest 0% ❌
core.sdk.src.api.firebolt 85% ✔
core.sdk.src.extn 76% ✔
core.main.src.broker.thunder 37% ❌
core.sdk.src.api.observability 57% ➖
core.sdk.src.extn.ffi 0% ❌
core.tdk.src.utils 0% ❌
device.thunder_ripple_sdk.src.client 61% ➖
core.sdk.src.service.mock_app_gw 0% ❌
device.thunder_ripple_sdk.src.processors.events 0% ❌
core.sdk.src.extn.client 82% ✔
device.thunder_ripple_sdk.src 13% ❌
core.main.src.processor.storage 0% ❌
core.main.src 0% ❌
core.sdk.src.service.mock_app_gw.appgw 0% ❌
Summary 49% (21113 / 43402) ➖

Minimum allowed line rate is 48%

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/903/rdkcentral/Ripple

  • Commit: c15c579

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: OK

  • Commit: c15c579
    '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maggie98choy maggie98choy maggie98choy approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Vinodsathyaseelan @rdkcmf-jenkins @maggie98choy